ci: run ci build related tests in parallel #1907
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcosta7
force-pushed
the
run-test-variants-in-parallel
branch
from
01f8ed3
to
550610d
Compare
mattcosta7
changed the title
kettanaito
reviewed
Dec 5, 2023
kettanaito
reviewed
Dec 5, 2023
|
|
||
| - name: Node.js tests | ||
| run: pnpm test:node | ||
|
|
||
| test_browser: |
There was a problem hiding this comment.
It's worth noting that ~85% of the test runtime is occupied by Playwright tests. We have around 200 tests there, and GitHub machines only has 2 cores, which means we are running all of them sequentially. This is the main bottleneck of CI performance for us right now.
There was a problem hiding this comment.
yep, totally.
In some cases though, being able to re-run the playwright tests a few times would be nice even if that was 7minutes each, without needing to rebuild, and run the other suites first. 3 minutes each x 5 runs is 15 minutes saved wall clock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
ci buildjob to run each of the test suites in parallel instead of serialThis should save some wall clock time when running the tests in ci, since browser tests can start immediately after build instead of only after unit, node, and native tests complete
We'd likely want to extend the required jobs configuration once this lands to require each of the test jobs to pass
In main, the current
buildjob is almost 10 minutes walltimein this branch it's closer to 7minutes, because each of the node/unit/native/browser suites run in parallel and avoid blocking eachother. the browser suite takes most of that wall-time still, but at least test suites won't block eachother
the big value, is that we can re-run one of these separate from the others